add fpc load balancer metrics #5240
Merged
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5240 +/- ##
===========================================
+ Coverage 44.53% 74.36% +29.82%
===========================================
Files 238 238
Lines 13957 13990 +33
Branches 570 569 -1
===========================================
+ Hits 6216 10403 +4187
+ Misses 7741 3587 -4154
Continue to review full report at Codecov.
|
jiangpengcheng
approved these changes
May 23, 2022
JesseStutler
pushed a commit
to JesseStutler/openwhisk
that referenced
this pull request
Jul 13, 2022
Co-authored-by: Brendan Doyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing load balancer metrics that previously existed in the old scheduler. Since there is no longer a concept of managed / blackbox to the load balancer, some of the metrics are just all encompassing now and not differentiated by invoker type. This is useful to see how large your invoker fleet currently is that's healthy and unhealthy without having to hit the controller's invoker endpoint and emitting your own status externally. Also added in the completion ack metrics which were also missing
Related issue and scope
My changes affect the following components
Types of changes
Checklist: